-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add a guide describing ownerReference usage in CAPI #9150
📖 Add a guide describing ownerReference usage in CAPI #9150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a gap here related to controller references: #4014
I'd prefer to keep that as a seperate issue here. We should probably add those references as part of the test and this doc simultaneously.
346698a
to
5be5b96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for taking care of this one. Overall lgtm
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
5be5b96
to
6bd6c6b
Compare
Thx! /lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: fb92eed94e172585e51a968e7efc83378de7ed57
|
/hold cancel I think this might be a bit of a WIP - e.g. #9153 - but happy with the current state for now. |
Yup definitely a reasonable first version that we can merge! |
/cherry-pick release-1.5 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #9154 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #9155 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This guide caps of work done on ownerReferences in Cluster API over the last ~12 months. It sets out a set of heuristics for using ownerReferences in Cluster API which may be useful for related projects as a reference.
It also documents in a simple way the current state of ownership relationships in Cluster API.
Related: #8256,
Fixes #5487